Conversation
fixes #150 Signed-off-by: Robert Waffen <rw@betadots.de>
Member
Author
|
@bootc pls have a look |
bootc
reviewed
Jun 23, 2026
Comment on lines
+7
to
+11
| if [ "$OPENVOX_USER_GID" -eq 999 ]; then | ||
| OPENVOX_GROUP=ping | ||
| else | ||
| OPENVOX_GROUP=puppet | ||
| fi |
Member
There was a problem hiding this comment.
This looks very odd, what's that about? On Alpine, if the OPENVOX_USER_GID is 999, the OPENVOX_GROUP should be called ping?
Member
There was a problem hiding this comment.
Oh this is because of #150 (comment). Tricky. I wonder whether the answer is to just have different UID/GID numbers on Ubuntu vs Alpine?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #150
This might be breaking for all users who have used the newer images after #131 . We have mistakenly switched the uid/gid to 1001 and are now reverting it back to 999.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent