Skip to content

Update sensory feedback impact payload handling#913

Merged
Kyle-Ye merged 1 commit into
mainfrom
optimize/feedback
Jun 16, 2026
Merged

Update sensory feedback impact payload handling#913
Kyle-Ye merged 1 commit into
mainfrom
optimize/feedback

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Split impact feedback intensity out of SensoryFeedback.FeedbackType into a separate payload.
  • Reuse UIKit feedback generators by feedback type while applying impact intensity at generation time.
  • Keep the existing FeedbackRequestContext.implementation(type:) entry point while routing UIKit feedback setup through the full SensoryFeedback value.

Motivation

Impact feedback generator style and impact intensity are separate concerns. Keying the UIKit feedback cache by a type that includes intensity can create extra generator entries for the same style. This update keeps the cache keyed by feedback type and carries intensity through the feedback payload instead.

@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance. labels Jun 16, 2026
@Kyle-Ye Kyle-Ye marked this pull request as ready for review June 16, 2026 17:28
@Kyle-Ye Kyle-Ye requested a review from Mx-Iris as a code owner June 16, 2026 17:28
@Kyle-Ye Kyle-Ye merged commit bb31b59 into main Jun 16, 2026
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the optimize/feedback branch June 16, 2026 17:29
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.84%. Comparing base (34f1c0c) to head (a5cd59d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...View/Control/SensoryFeedback/SensoryFeedback.swift 0.00% 5 Missing ⚠️
...rol/SensoryFeedback/SensoryFeedbackGenerator.swift 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (34f1c0c) and HEAD (a5cd59d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (34f1c0c) HEAD (a5cd59d)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #913       +/-   ##
===========================================
- Coverage   26.04%   13.84%   -12.20%     
===========================================
  Files         717      674       -43     
  Lines       50566    44284     -6282     
===========================================
- Hits        13168     6132     -7036     
- Misses      37398    38152      +754     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant