Skip to content

fix(spp_approval): use ace 'javascript' mode for CEL fields

ffd42c5
Select commit
Loading
Failed to load commit list.
Merged

Bug: CEL Expressions tab crashes and hidden menus reset on upgrade #166

fix(spp_approval): use ace 'javascript' mode for CEL fields
ffd42c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 4, 2026 in 1s

73.06% (+0.00%) compared to 1460aa5

View this Pull Request on Codecov

73.06% (+0.00%) compared to 1460aa5

Details

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.06%. Comparing base (1460aa5) to head (ffd42c5).

Files with missing lines Patch % Lines
spp_hide_menus_base/models/hide_menu.py 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             19.0     #166   +/-   ##
=======================================
  Coverage   73.06%   73.06%           
=======================================
  Files        1069     1069           
  Lines       62105    62120   +15     
=======================================
+ Hits        45377    45390   +13     
- Misses      16728    16730    +2     
Files with missing lines Coverage Δ
spp_approval/__manifest__.py 0.00% <ø> (ø)
spp_hide_menus_base/__manifest__.py 0.00% <ø> (ø)
spp_hide_menus_base/models/ir_module_module.py 90.32% <100.00%> (+2.32%) ⬆️
spp_hide_menus_base/models/hide_menu.py 87.17% <77.77%> (-2.83%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.