Conversation
simongu
requested review from
andylau-55,
caszkgui and
matthewhyx
as code owners
September 18, 2026 02:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
NullPointerExceptionobserved when running eval (see #732): reader/retrieval sync tasks dereference aBuilderJobthat no longer exists, causing a bare NPE at execution time.RetrievalSyncTask— null-checkbuilderJobat entry andretrievalinside the loop (both could benull).KagReaderSyncTask— null-checkbuilderJobbeforereadSource, so anulljob is never passed down.common/util CommonUtils#getScannerReaderConfig/getKagBuilderInput— guardjob == null(defense in depth for the read bridge path).BuilderController#delete— governance fix: when aBuilderJobis deleted, also tear down its linkedSchedulerJob(schedulerService.deleteJob(taskId)), so its DAG instances do not keep running sync tasks against a BuilderJob that no longer exists.Files changed
server/core/.../task/sync/builder/RetrievalSyncTask.javaserver/core/.../task/sync/builder/KagReaderSyncTask.javacommon/util/.../CommonUtils.javaserver/api/http-server/.../openapi/BuilderController.javaTest plan
mvn -pl common/util,server/core/scheduler/service -am compileCloses #732