Repository navigation
ppd-filter: fix & typo in the filter-streaming-mode check - #102
Merged
tillkamppeter merged 1 commit intoNov 3, 2026
Merged
Conversation
the check for filter-streaming-mode used & instead of && between the "off" and "no" comparisons. strcasecmp("on", "off") & strcasecmp("on", "no") is 8 & 1 == 0 with glibc, so filter-streaming-mode=on never actualy turned Streaming mode on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one-character fix:
ppdFilterEmitJCL()has a&where&&was ment in thefilter-streaming-modecheck.with glibc,
strcasecmp("on", "off") & strcasecmp("on", "no")comes out as8 & 1 == 0, sofilter-streaming-mode=onis treated like "off" and the job still goes through full pdftopdf processing. "true", "yes" and "1" happen to work just by luck of the bit patterns.checked with a small program running the old and new expressions over those values.