Fix PageSize/media to PPD mapping for non-Adobe names. Fixes #1375#1587
Open
ValdikSS wants to merge 1 commit into
Open
Fix PageSize/media to PPD mapping for non-Adobe names. Fixes #1375#1587ValdikSS wants to merge 1 commit into
ValdikSS wants to merge 1 commit into
Conversation
…ting#1375 If the client software sends only PageSize using Adobe name (common when printer is shared), but the PPD file uses non-Adobe name, default page size was used, which is incorrect. The previous attempt in commit 226f509 to fix this issue have missed loading PPD cache if no media is supplied.
ValdikSS
force-pushed
the
1375-fix-ppd-cache
branch
from
c32f949 to
257df01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the client software sends only PageSize using Adobe name (common when printer is shared), but the PPD file uses non-Adobe name, default page size was used, which is incorrect.
The previous attempt in commit 226f509 to fix this issue have missed loading PPD cache if no media is supplied.