feat: add TrainerRank#731
Draft
bradhilton wants to merge 11 commits into
Draft
Conversation
2cecc5a to
94afb0f
Compare
…-tree # Conflicts: # scripts/build-gpu-image.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
art.megatron.trainer_rankplus a minimaldev/trainer_rank.pytorchrun demoValidation
uv run ruff check src/art/megatron/context_parallel/builder.py src/art/megatron/shared_prefix_state.py tests/unit/test_shared_prefix_attention_builder.py dev/trainer_rank_perf.pyuv run pytest tests/unit/test_shared_prefix_packing.py tests/unit/test_shared_prefix_tree.py tests/unit/test_shared_prefix_grad_parity.py tests/unit/test_trainer_rank_validation.py tests/unit/test_shared_prefix_attention_builder.py(34 passed, 8 skippedlocally; Megatron-only attention builder passes on H200)7 passed7 passed, 2 skipped4 passed, 2 skipped1 passed120/120passed across DP/TP/CP <= 4 and depths 0..3