Fix cargo_container mass for flops based off design missions - #1254
Open
cmbenne3 wants to merge 5 commits into
Open
Fix cargo_container mass for flops based off design missions#1254cmbenne3 wants to merge 5 commits into
cmbenne3 wants to merge 5 commits into
Conversation
| inputs.set_val(Aircraft.CrewPayload.CARGO_CONTAINER_MASS, cargo_container_mass, 'lbm') | ||
| if verbosity >= Verbosity.BRIEF: | ||
| warnings.warn( | ||
| f'Setting CARGO_CONTAINER_MASS for off design mission equal to design mission = {cargo_container_mass} lbm' |
Member
There was a problem hiding this comment.
Probably should test this, maybe could piggyback on the existing off design tests, if the cargo container mass recomputes on them.
jkirk5
approved these changes
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick change to fix cargo_container_mass for off design FLOPS missions.
Aircraft.CrewPayload.CARGO_CONTAINER_MASS is summed into Mission.OPERATING_ITEMS_MASS, which is in turn part of Mission.OPERATING_MASS.
If the cargo load or baggage load (e.g. num passengers) changes between design and off_design then the number of cargo containers will recalculate and change the OPERATING_MASS
It is confusing if this changes between a design and off design mission.
This PR now checks the value from design mission and adds an override for this value in the off_design problem so that it doesn't change.
This is similar to the FLOPS behavior when mywts = 1 is set in a rerun namelist. (it's not identical as FLOPS actually carries the operating empty weight (dowe) across directly (or overwrites with user value) when mywts=1.)
With this change Mission.OPERATING_MASS could now be updated to Aircraft.Design.OPERATING_MASS as I don't think it will ever change between design and off design.
Related Issues
Backwards incompatibilities
None
AI Usage
Disclose any AI usage in this PR, including models used and files affected.