Fix duplicate opendj-server-legacy classes in distribution lib/#661
Open
vharseko wants to merge 2 commits into
Open
Fix duplicate opendj-server-legacy classes in distribution lib/#661vharseko wants to merge 2 commits into
vharseko wants to merge 2 commits into
Conversation
The dependencySet exclude in opendj-archive-component.xml used the pre-fork groupId org.forgerock.opendj, so it no longer matched the module's own artifact (org.openidentityplatform.opendj). As a result lib/ shipped both opendj.jar and an identical org.openidentityplatform.opendj.opendj-server-legacy.jar. Correct the groupId so the duplicate is excluded; opendj.jar remains the canonical jar referenced by the bootstrap manifests.
maximthomas
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The assembled server distribution shipped two byte-identical copies of the same 2975
org.opends.server.*classes inlib/:lib/opendj.jar— the canonical jar (referenced by the bootstrap manifests, upgrade and doc tooling)lib/org.openidentityplatform.opendj.opendj-server-legacy.jar— an unwanted duplicate (~8 MB)Root cause
The
<dependencySet>inopendj-server-legacy/src/main/assembly/opendj-archive-component.xmlincludes the module's own artifact (useProjectArtifactdefaults totrue) and was supposed to drop it via an<exclude>. After the fork from ForgeRock the projectgroupIdchanged toorg.openidentityplatform.opendj, but the exclude still used the pre-fork coordinateorg.forgerock.opendj:opendj-server-legacy, so it no longer matched and the duplicate was copied in.Fix
One line — correct the
groupIdin the exclude so the duplicate is filtered out.opendj.jarstays as the canonical jar. Nothing references the duplicate by name (verified across manifests, scripts, Dockerfiles and package specs), and all downstream packages (DEB/RPM/MSI/SVR4/Docker) reuse this distribution, so the duplicate is removed everywhere.Verification
Built
opendj-server-legacyand confirmed:lib/no longer containsorg.openidentityplatform.opendj.opendj-server-legacy.jar;opendj.jaris presentbootstrap-client.jarmanifestClass-Pathstill referencesopendj.jarsetup(sample data) →status(Started, 102 entries) →ldapsearch→dsconfig(admin connector) →stop-ds, noNoClassDefFoundError