Repository navigation
Add OCI standard version and drop "v" from image - #738
Draft
taylordowns2000 wants to merge 1 commit into
Draft
taylordowns2000 wants to merge 1 commit into
taylordowns2000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligning across OpenFn/lightning#5265, OpenFn/kit#1604, https://github.com/OpenFn/deployment/pull/560
Changes
openfn/apollo:3.5.2instead ofopenfn/apollo:v3.5.2. Tags come fromdocker/metadata-action@v5usingtype=semver, as in kit.org.opencontainers.image.*labels from the metadata step.@openfn/apollo@prefix from the tag, the version must look like semver (e.g.3.5.2or1.4.0-pre.0). Otherwise the job fails with a clear error instead of pushing a badly named tag.:latestrule kept::lateststill only moves for final releases, never for pre-releases like1.4.0-pre.0.type=semverdoes this by default.A more detailed breakdown of the changes, including motivations (if not provided
in the issue).
AI Usage
Please disclose whether you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy