Dev Platform for MEC1723#25
Merged
felipebalbi merged 15 commits intoMay 27, 2026
Merged
Conversation
bjackson312006
requested review from
Copilot,
dymk,
kat-perez,
maxperga-msft and
rogurr
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
kurtjd
requested changes
May 26, 2026
felipebalbi
previously approved these changes
May 26, 2026
Contributor
felipebalbi
left a comment
felipebalbi
left a comment
There was a problem hiding this comment.
Looks good to me. Would like the mec UART changes going upstream, though 😄
felipebalbi
previously approved these changes
May 26, 2026
…t with the embassy example
bjackson312006
force-pushed
the
dev-mec1723
branch
from
f1d2687 to
ce79c84
Compare
kurtjd
approved these changes
May 26, 2026
felipebalbi
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
dev-mec1723platform crate for the Microchip MEC1723 controller. This crate has been tested and validated on the EV71E60A MEC1723 eval board we have.Things of note:
git = "https://github.com/bjackson312006/embassy", rev = "e85b387cf915241a1d9e0ba32ab4a7a1117896b3"), which implements a fix toUartRx::read()in theembassy-microchip/uart.rsdriver. That branch can be viewed here, but it isn't intended to be merged upstream anytime soon since it is based on @kurtjd's buffered UART hack branch.DEFMT_LOG = "info"(rather than"trace") incargo.tomlbecause the abundance of [TRACE] prints were indirectly causing timing issues with UART for some reason.Resolves #20