Repository navigation
Preserve VLA source capacity for unequal-allocator moves - #218
Draft
thirtytwobits wants to merge 1 commit into
Draft
thirtytwobits wants to merge 1 commit into
thirtytwobits wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocator-extended move construction with unequal allocators currently frees the source buffer after relocating its elements. Retain that allocation and capacity while emptying the source, matching unequal-allocator move assignment. This permits source reuse without another allocation; callers can explicitly release storage with
shrink_to_fit().Equal-allocator moves still transfer storage. Destination allocation sizing and the existing move-assignment policy of releasing an insufficient destination buffer before replacement are preserved. Document the successful-move contract and the separate exception guarantees, and remove no-op allocator assignment calls.
Regression coverage checks ordinary elements, packed bool, empty reserved sources, both move-assignment capacity branches, source reuse and explicit release, copy fallback, move-only elements, allocator destruction hooks, and successful retry after allocation failure. The new constructor-retention tests failed against the original implementation before the fix.
Validation:
git diff --checkpassed.type_traits_ext.hppandunbounded_variant.hpp.Fixes #211.