Skip to content

Dev warning for inline localeText functions; select editor browser tests - #9

Open
asif7774 wants to merge 2 commits into
mainfrom
fix/localetext-functions
Open

asif7774 wants to merge 2 commits into
mainfrom
fix/localetext-functions

Conversation

@asif7774

Copy link
Copy Markdown
Member

Summary

  • localeText warning (dev only): inline function entries in localeText re-render every rendered row on each parent render (rows read the locale from context). The grid now warns once, naming the entries, after three renders in a row re-create the same function. Functions are deliberately not frozen: that would leave row labels stale after a language switch.
  • Select editor browser tests: mouse and keyboard editing of a select cell in Chromium, Firefox and WebKit (42 pass). F2 / type-to-edit are not implemented and are marked it.fails (6 expected fails).
  • Tracker: B8/B9 closed as won't fix (by design, documented in docs/features/filtering.md).

Not covered automatically

The native select popup (choosing inside the open list, Enter/Escape while it is open) is not rendered by headless browsers; check manually in desktop Chrome, Firefox and Safari.

Checks

lint, typecheck, build, check:compiler, check:versions, unit 1991/1991, new browser file 3 engines.

🤖 Generated with Claude Code

…tions

Every rendered row reads the locale from context, so a localeText with
inline function entries re-rendered all rows on each parent render.
Warn once, naming the entries, after three renders in a row re-create a
function with the same source. The functions are not frozen: one that
reads new state (a language switch) must still update the rows.

Tracker: B8/B9 closed as won't fix (by design).
…ee engines

Open, pick, commit on click-away / Enter / Tab / Shift+Tab, Escape
restores the old value, arrows stay with the select. F2 and
type-to-edit are not implemented and are marked it.fails.
@ecc-tools

ecc-tools Bot commented Oct 16, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: 9db153f279b15404194ea1c907d27e2660ef4253

Security scanner evidence required (action_required)

Detected 1 security-sensitive predictive risk signal(s) without scanner evidence.

Mode: enforce

Findings:

  • Security-sensitive changes may ship without scanner evidence: The PR touches billing, secrets, auth, webhooks, agent, or CI-sensitive surfaces without adding obvious security scanner, code scanning, or security-focused validation evidence. (2 security-sensitive paths changed; 0 security scanner or security-focused validation artifacts changed)

Touched security-sensitive paths:

  • lib/hooks/core/useGridLocaleTextWarning.test.ts
  • lib/hooks/core/useGridLocaleTextWarning.ts

Expected evidence:

  • Security scanner, code scanning, secret scanning, dependency/security review, or focused security regression output.
  • SARIF/code-scanning upload or equivalent pass/fail gate for the changed surface.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Oct 16, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: 9db153f279b15404194ea1c907d27e2660ef4253

PR taxonomy review recommended (neutral)

Detected 2 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation.

Scanned 7 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

  • Security-sensitive changes may ship without scanner evidence
  • 0 security-sensitive path(s) changed

Paths:

  • CHANGELOG.md
  • docs/performance.md
  • docs/superpowers/plans/2026-10-13-audit-tracker.md

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • User-facing UI changes may ship without browser coverage
  • 2 CI or workflow path(s) changed

Paths:

  • lib/components/Cell/GridEditInputCell.select.browser.test.tsx
  • lib/hooks/core/useGridLocaleTextWarning.test.ts
  • lib/components/DataGrid/GridRoot.tsx
  • lib/hooks/core/useGridLocaleTextWarning.ts

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Oct 16, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: 9db153f279b15404194ea1c907d27e2660ef4253

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 7 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Oct 16, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: 9db153f279b15404194ea1c907d27e2660ef4253

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 7 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant