Skip to content

climatology 1.6.36.1#1365

Open
rgleason wants to merge 1 commit intoOpenCPN:masterfrom
rgleason:master
Open

climatology 1.6.36.1#1365
rgleason wants to merge 1 commit intoOpenCPN:masterfrom
rgleason:master

Conversation

@rgleason
Copy link
Copy Markdown
Contributor

@rgleason rgleason commented May 4, 2026

No description provided.

@quinton-hoole
Copy link
Copy Markdown

Please don't publish this in the master catalogue until it has been tested in all platforms. It has only been tested on Windows, as far as I'm aware.

It could be published to the alpha or beta plugins catalog to allow further testing before being added to the master catalog please 🙏

@quinton-hoole
Copy link
Copy Markdown

quinton-hoole commented May 6, 2026

@rgleason I tested the packages in cloudsmith on Debian 13, MacOS 26.3.1 and Windows 11 as you requested here. The plugin does not appear to work correctly on any of them, specifically:

  1. On Debian, when trying to import the plugin, I got an error "Incompatible import plugin detected". I get no such error when installing the existing version of the plugin (1.6.35.0) from the current master plugin catalog. I was not able to test any further.
  2. On MacOS, in the About box, the text describing all of the data, has now disappeared. This is not the case with the current version in the master plugin catalog (1.6.35.0) which displays the text correctly. I assume that this might be either because the file ClimatologyInformation.html was edited by you yesterday or because the download procedure was changed two days ago.
  3. On Windows, the same problem as above occurs (ClimatologyInformation.html is not displayed in the about box).

More generally I'm not sure that the changes introduced in this proposed release (v1.6.36.1) are needed. The plugin works fine in the existing release (v1.6.35.1) in the master catalog. Most of the proposed changes introduced in v1.6.36.1 in rgleason/climatology_pi#75 appear to be in response to rgleason/climatology_pi#67 but most if not all of the changes appear not to be needed.

@quinton-hoole
Copy link
Copy Markdown

@rgleason All of the data in the climatology plugin is read using the zu_read() function, which decompresses on the fly. So there is no need to add all of the decompression code that you added to the main body of the plugin above. That is why the plugin worked just fine before you added all the new decompression code.

I think we should probably back out all of the recent code changes and start over again with clear goals and a plan.

We can move this discussion to the climatology_pi repo, and sort it all out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants