ci: standardize and tighten permissions across reusable workflows - #33
Merged
Merged
Conversation
Ensure all reusable workflows follow a consistent permission model: - Explicit baseline of `contents: read` at the workflow level - Job-level overrides for any elevated permissions (e.g., write, packages, id-token, attestations, security-events) Fix docker-build-release.yml by removing invalid step-level permissions and scoping required rights to the build-push-images job only. This resolves GitHub's validation error when called from workflows that do not grant the full `write-all` set. Apply the same discipline to all other workflows, adding explicit permissions and descriptive comments where missing. This enforces least-privilege and makes future audits straightforward. Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
seantronsen
reviewed
Sep 16, 2026
seantronsen
approved these changes
Sep 16, 2026
Contributor
|
🪨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure all reusable workflows follow a consistent permission model:
contents: readat the workflow levelFix docker-build-release.yml by removing invalid step-level permissions and scoping required rights to the build-push-images job only. This resolves GitHub's validation error when called from workflows that do not grant the full
write-allset.Apply the same discipline to all other workflows, adding explicit permissions and descriptive comments where missing. This enforces least-privilege and makes future audits straightforward.
Fixes failed cloud-init release run: https://github.com/OpenCHAMI/cloud-init/actions/runs/34624459891
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change