Skip to content

ci: add skip publish on fork pr builds - #19

Merged
synackd merged 2 commits into
mainfrom
seantronsen/standardization
Sep 15, 2026
Merged

synackd merged 2 commits into
mainfrom
seantronsen/standardization

Conversation

@seantronsen

Copy link
Copy Markdown
Contributor

Description

Adds a build/publish check for fork PRs.

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

@synackd

synackd commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

This is marked as a WIP. Is this ready for review or is this still being worked on?

@seantronsen
seantronsen force-pushed the seantronsen/standardization branch from 036ec44 to c2f3b76 Compare September 14, 2026 23:26
@seantronsen seantronsen changed the title wip: add skip publish on fork pr builds add skip publish on fork pr builds Sep 14, 2026
@seantronsen

seantronsen commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

This is marked as a WIP. Is this ready for review or is this still being worked on?

whoops. good catch. artifact from the commit this morning. I decided after I got home that I'd split into multiple PRs to simplify review efforts.

TLDR: it's good to go. I renamed the commit to promote sanity @synackd .

@synackd synackd changed the title add skip publish on fork pr builds ci: add skip publish on fork pr builds Sep 15, 2026
Comment thread .github/workflows/build-publish-container-goreleaser.yml
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen force-pushed the seantronsen/standardization branch from c2f3b76 to d8304be Compare September 15, 2026 14:38
@seantronsen
seantronsen requested a review from synackd September 15, 2026 14:49
@synackd
synackd merged commit b1ba49b into main Sep 15, 2026
2 checks passed
@synackd
synackd deleted the seantronsen/standardization branch September 15, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants