Skip to content

fix quotation mark in CMakeLists.txt#2

Open
jp112sdl wants to merge 8 commits into
OpenCCU:mainfrom
jp112sdl:fix_CMakeLists_quotation
Open

fix quotation mark in CMakeLists.txt#2
jp112sdl wants to merge 8 commits into
OpenCCU:mainfrom
jp112sdl:fix_CMakeLists_quotation

Conversation

@jp112sdl

@jp112sdl jp112sdl commented Jul 6, 2026

Copy link
Copy Markdown
Member

... due to compilation error (generated-*-version.h not found)

Summary by CodeRabbit

  • Bug Fixes
    • Improved the reliability of version information generation during builds for multiple components.
    • Helped ensure generated version headers are created consistently across build environments.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jp112sdl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd0c2e97-27df-47e3-9a35-78adc73f4a4d

📥 Commits

Reviewing files that changed from the base of the PR and between 11169f2 and 418c5bb.

⛔ Files ignored due to path filters (1)
  • lib/x86_64-linux-gnu/libelvutils.so is excluded by !**/*.so
📒 Files selected for processing (16)
  • addons/asksinanalyzer/.gitignore
  • addons/asksinanalyzer/README.md
  • addons/asksinanalyzer/VERSION
  • addons/asksinanalyzer/build-addon.sh
  • addons/asksinanalyzer/pkg/rc.d/asksinanalyzer
  • addons/asksinanalyzer/pkg/update_script
  • addons/asksinanalyzer/www/api.cgi
  • addons/asksinanalyzer/www/index.html
  • bin/x86_64-linux-gnu/multimacd
  • src/multimacd/MultimacManager.cpp
  • src/multimacd/Subsystem.cpp
  • src/multimacd/SubsystemManager.cpp
  • src/multimacd/TrafficLogger.cpp
  • src/multimacd/TrafficLogger.h
  • src/multimacd/multimacd.conf
  • src/multimacd/multimacd.cpp
📝 Walkthrough

Walkthrough

This change modifies the quoting/formatting of the -DOUTPUT argument passed to WriteVersionHeader.cmake within add_custom_command invocations in src/hs485d/CMakeLists.txt, src/multimacd/CMakeLists.txt, and src/rfd/CMakeLists.txt. No other logic or dependencies are changed.

Changes

CMake Version Header Generation

Layer / File(s) Summary
-DOUTPUT argument quoting adjustments
src/hs485d/CMakeLists.txt, src/multimacd/CMakeLists.txt, src/rfd/CMakeLists.txt
Each file's add_custom_command for generating a version header changes how the -DOUTPUT=... argument is quoted when invoking WriteVersionHeader.cmake, with input files, macro names, and overall command structure unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related Issues: None specified.

Related PRs: None specified.

Suggested labels: build, cmake

Suggested reviewers: None specified.

Poem

A rabbit hopped through CMake's script,
Quoting marks it gently flicked,
Output paths now dressed anew,
Same old version, different view,
Hop, hop, build — the header's picked!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the core change: a quotation mark fix in CMakeLists files causing version header generation issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jp112sdl jp112sdl marked this pull request as ready for review July 6, 2026 10:29
jp112sdl and others added 7 commits July 6, 2026 12:42
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…log)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
update_script + rc.d script for WebUI Zusatzsoftware integration,
build-addon.sh creates the distributable tar.gz.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant