Skip to content

Fix spectral arrow advancement trigger - #124

Closed
HP-network wants to merge 1 commit into
OpenBagTwo:26.2from
HP-network:fix/spectral-arrow-advancement
Closed

HP-network wants to merge 1 commit into
OpenBagTwo:26.2from
HP-network:fix/spectral-arrow-advancement

Conversation

@HP-network

Copy link
Copy Markdown

Fixes #122

The advancement criterion listens for lighterend:combat/spectral_arrow, but the generated recipe is lighterend:spectral_arrow. Crafting spectral arrows therefore never grants the existing "Making a Point" advancement.

This updates the criterion to use the generated recipe ID.

Validation:

  • Confirmed the baseline IDs differ and the modified IDs match.
  • git diff --check passes.

@OpenBagTwo

Copy link
Copy Markdown
Owner

Thanks for this. Did you test this in-game?

Same as the other PR, this isn't something I'm going to address until after 26.3 is released. I'm also probably going to use the template of the sherds-to-pot advancement.

@HP-network

Copy link
Copy Markdown
Author

I have not run a full in-game client session yet. I verified the generated recipe ID and advancement criterion against the source data: both now resolve to lighterend:spectral_arrow, and git diff --check passes. I will leave this open for your 26.3 release testing.

@OpenBagTwo

Copy link
Copy Markdown
Owner

I'm doing this a bit differently (I want to explicitly disallow getting the enchantment using a feather). But thanks for the input!

@OpenBagTwo OpenBagTwo closed this Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advancement "Making a Point" doesn't work

2 participants