Repository navigation
Fix spectral arrow advancement trigger - #124
Closed
HP-network wants to merge 1 commit into
Closed
HP-network wants to merge 1 commit into
HP-network wants to merge 1 commit into
Conversation
Owner
|
Thanks for this. Did you test this in-game? Same as the other PR, this isn't something I'm going to address until after 26.3 is released. I'm also probably going to use the template of the sherds-to-pot advancement. |
Author
|
I have not run a full in-game client session yet. I verified the generated recipe ID and advancement criterion against the source data: both now resolve to |
Owner
|
I'm doing this a bit differently (I want to explicitly disallow getting the enchantment using a feather). But thanks for the input! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122
The advancement criterion listens for
lighterend:combat/spectral_arrow, but the generated recipe islighterend:spectral_arrow. Crafting spectral arrows therefore never grants the existing "Making a Point" advancement.This updates the criterion to use the generated recipe ID.
Validation:
git diff --checkpasses.