fix: replace atexit with BackgroundTask for temp zip cleanup#624
Open
hobostay wants to merge 1 commit into
Open
fix: replace atexit with BackgroundTask for temp zip cleanup#624hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
Using atexit to clean up temporary zip files is unreliable because atexit handlers only run when the process exits, not after each download. This means temp files accumulate on disk, one per download, until the server restarts. Replace with Starlette's BackgroundTask which runs cleanup after the response is fully sent, ensuring temp files are deleted promptly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atexit.register(cleanup_zip)with Starlette'sBackgroundTaskfor cleaning up temporary zip files after session downloadsatexithandlers only run at process shutdown, so every download accumulates a temp zip file on disk until the server restartsBug Details
In
server/routes/sessions.py, after creating a temporary zip archive for download, the cleanup is registered viaatexit:Problem:
atexithandlers only run when the Python process exits. In a long-running server, this means:atexit.registercall also adds to a growing list of callbacksFix: Use Starlette's
BackgroundTaskwhich runs after the HTTP response is fully sent.Test plan
🤖 Generated with Claude Code