chore: reject writes after canvas halts and retain diagnostics - #479
Merged
Merged
Conversation
Signed-off-by: Richard Abrich <richard.abrich@mldsai.com>
Signed-off-by: Richard Abrich <richard.abrich@mldsai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A severe-drift canvas trial could report a safe halt after saving the wrong note or an empty row. The oracle only counted the expected note as a write. Require the saved-note file to be absent: every persisted value now fails, and Docker or read errors stop qualification instead of becoming evidence of no write.
Each trial also retains a bounded native diagnostic summary with the first failed result index, refusal enums, delivery flags, and identity/resolution metrics. It excludes report text, OCR values, parameters, paths, and frames. The existing artifact uploads only
results.json, with seven-day retention. Runtime behavior is unchanged.Validation: 38 focused canvas and CI workflow tests pass, including wrong-note and empty-row rejection, the exact file probe against local files, failed-read handling, and secret-canary checks. Ruff and release consistency pass. These tests cover the qualification oracle and diagnostic export. We haven't rerun the live canvas environment, so the September 9 moderate over-halt still needs native failure evidence.
Opened by an agent session, not the founder.