Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
peter-em
force-pushed
the
feature/support-examples-in-codegen-property
branch
from
September 25, 2026 13:58
ae66997 to
5d5d531
Compare
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Re-trigger cubic
peter-em
force-pushed
the
feature/support-examples-in-codegen-property
branch
2 times, most recently
from
September 25, 2026 14:47
298fee1 to
cc246ef
Compare
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
peter-em
force-pushed
the
feature/support-examples-in-codegen-property
branch
from
September 25, 2026 14:58
cc246ef to
d156fdc
Compare
peter-em
force-pushed
the
feature/support-examples-in-codegen-property
branch
from
September 25, 2026 16:21
d156fdc to
7cb1aa5
Compare
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added handling of examples keyword for OAS 3.1 spec.
They are generated in the corresponding
@Schemaannotation, next to the singular exampleResolve #24755
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Java | @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) @KannaKim (2026/07)
Java Spring | @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08) @KannaKim (2026/07)
Summary by cubic
Adds support for the OAS 3.1
exampleskeyword so Java Spring generators emit it in the@Schemaannotation alongside the singularexample.examplesproperty toCodegenProperty, populated from the schema'sexampleslist via newtoExampleValues/getExampleValueToStringhooks that stringify scalar, array, and object values.AbstractJavaCodegen.toExampleValuesoexampleandexamplesshare the same string escaping andDatehandling; error reporting is consolidated inhandleExampleException.pojo.mustachetemplate to renderexamples = { ... }only when at least one value is present.issue_24755.yaml) covering string, integer, array, object, and empty examples lists.Resolves #24755.
Written for commit d156fdc. Summary will update on new commits.