Skip to content

refactor(typescript-fetch): centralize date type handling in TypeScriptFetchClientCodegen - #24715

Open
Mattias-Sehlstedt wants to merge 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:typescript-date-type-handling
Open

refactor(typescript-fetch): centralize date type handling in TypeScriptFetchClientCodegen#24715
Mattias-Sehlstedt wants to merge 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:typescript-date-type-handling

Conversation

@Mattias-Sehlstedt

@Mattias-Sehlstedt Mattias-Sehlstedt commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

There are several incentives to support better and consistent date handling for typescript-fetch #24714, #24637. I saw that they had to define the same thing over and over again when they were technically referring to the exact same thing.

I have gathered the definition in a single location so that any further change will be easier to follow and understand.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Centralizes date type handling in TypeScriptFetchClientCodegen to keep date/DateTime mapping consistent and easier to maintain. No behavior change: both date and DateTime still generate TypeScript Date, and type checks use the new helpers.

  • What to review
    • Mapping for date and DateTime now references constants and shared helpers (isDateType, isDateTimeType) instead of inline "Date" comparisons.
    • Verify typescript-fetch samples show no generated diffs.

Written for commit bc4ca5d. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant