Skip to content

fix: [SDK-5161] support shared template notification actions - #1179

Merged
fadi-george merged 5 commits into
mainfrom
fadi/sdk-5161
Sep 8, 2026
Merged

fadi-george merged 5 commits into
mainfrom
fadi/sdk-5161

Conversation

@fadi-george

Copy link
Copy Markdown
Collaborator

One Line Summary

Adds shared iOS template action-button icons to Flutter demos and fixes Android grouped-notification click serialization.

Motivation

Template action icons must be bundled in both the app and notification service extension. During cross-wrapper verification, grouped summary clicks also exposed that Flutter passed native notification objects over the method channel instead of serializable maps.

Scope

  • Add template-bookmark-icon.png and template-share-icon.png to five iOS demos.
  • Include both icons in the Runner and OneSignalNotificationServiceExtension resource phases.
  • Document dashboard icon names and iOS verification steps.
  • Recursively serialize Android grouped notifications as maps.
  • Accept mapped grouped-notification lists while retaining legacy JSON-string parsing.
  • Add grouped-notification parsing regression coverage.

Testing

  • flutter test test/notification_test.dart (40 tests passed)
  • examples/demo/android/gradlew :onesignal_flutter:compileDebugJavaWithJavac
  • Validated all modified Xcode project files with plutil -lint.
  • Verified Runner and NSE resource membership in all five demos.
  • Physical iOS 15+ icon rendering remains to be verified.

Affected code checklist

  • Android bridge serialization
  • Dart notification model and tests
  • iOS demo resources and Xcode projects
  • Demo documentation

Checklist confirmations

  • No public API fields were removed or renamed.
  • Existing grouped-notification JSON-string parsing remains supported.
  • Relevant automated tests and builds pass.
  • Documentation describes icon configuration without the .png suffix.

@fadi-george
fadi-george requested a review from a team as a code owner September 3, 2026 01:35

@abdulraqeeb33 abdulraqeeb33 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android grouped children now serialize as maps, and Dart still accepts the legacy JSON-string path. Demo icons land in Runner and NSE. Approving.

@fadi-george
fadi-george merged commit 5a06d88 into main Sep 8, 2026
5 checks passed
@fadi-george
fadi-george deleted the fadi/sdk-5161 branch September 8, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants