Skip to content

Reservation: Adds a virtual resource for every real resource - #2743

Draft
Daverball wants to merge 4 commits into
masterfrom
ogc-3386-internal-reservations
Draft

Daverball wants to merge 4 commits into
masterfrom
ogc-3386-internal-reservations

Conversation

@Daverball

Copy link
Copy Markdown
Member

Commit message

Reservation: Adds a virtual resource for every real resource

This allows us to have two layers of allocations, where reservations
still block each other, but the allocations themselves do not. This
works exactly the same as parent/child resources work.

This second layer is intended for internal reservations, where
availability is essentially unrestricted apart from any time spans that
have already been reserved, so full-day partly available allocations
are created on-demand, rather than explicitly managed.

TYPE: Feature
LINK: OGC-3386

Checklist

  • I have performed a self-review of my code
  • I have updated the PO files
  • I made changes/features for both org and town6
  • I have tested my code thoroughly by hand
  • I have added tests for my changes/features

This allows us to have two layers of allocations, where reservations
still block each other, but the allocations themselves do not. This
works exactly the same as parent/child resources work.

This second layer is intended for internal reservations, where
availability is essentially unrestricted apart from any time spans that
have already been reserved, so full-day partly available allocations
are created on-demand, rather than explicitly managed.

TYPE: Feature
LINK: OGC-3386
@linear

linear Bot commented Oct 15, 2026

Copy link
Copy Markdown

OGC-3386

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.58140% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.73%. Comparing base (fb36f99) to head (69a68a1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onegov/org/cronjobs.py 54.54% 5 Missing ⚠️
src/onegov/reservation/models/resource.py 83.87% 5 Missing ⚠️
src/onegov/org/path.py 75.00% 3 Missing ⚠️
src/onegov/org/views/allocation.py 50.00% 2 Missing ⚠️
src/onegov/org/views/resource.py 0.00% 2 Missing ⚠️
src/onegov/org/views/ticket.py 50.00% 2 Missing ⚠️
src/onegov/org/utils.py 66.66% 1 Missing ⚠️
src/onegov/reservation/models/custom_allocation.py 75.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/core/orm/session_manager.py 99.33% <ø> (ø)
src/onegov/org/models/ticket.py 88.70% <100.00%> (-0.03%) ⬇️
src/onegov/org/views/reservation.py 73.56% <100.00%> (ø)
src/onegov/reservation/collection.py 96.25% <100.00%> (+0.41%) ⬆️
...rc/onegov/reservation/models/custom_reservation.py 91.57% <100.00%> (+0.27%) ⬆️
src/onegov/org/utils.py 86.87% <66.66%> (-0.10%) ⬇️
src/onegov/reservation/models/custom_allocation.py 82.35% <75.00%> (+3.78%) ⬆️
src/onegov/org/views/allocation.py 90.58% <50.00%> (-0.49%) ⬇️
src/onegov/org/views/resource.py 84.05% <0.00%> (+0.22%) ⬆️
src/onegov/org/views/ticket.py 86.27% <50.00%> (-0.10%) ⬇️
... and 3 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb36f99...69a68a1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant