fix: issue #15 add subscription callback for NodeViewContext - #60
Merged
Conversation
added 4 commits
August 5, 2026 22:58
…emove subscriptions
…emove subscriptions
|
First, it's issue #40 , not 15. Second, u didn't finish it yet. There's still EventBridge in these codes. Converted it into draft. |
Mike-Solar
marked this pull request as draft
August 5, 2026 16:12
- Delete bridge_ and node_subs member variables - Remove all event subscribe/unsubscribe code blocks - Eliminate event‑driven UI update, rely on manual update_rect call - Clear all OAKENGINE_EVENT related code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #15
Bind project load finished signal to update rect in NodeViewContext.
Only modified nodeviewcontext.cpp.