Fix NoSQL injection in allocations-dao (CWE-943) - #464
Open
it24103309 wants to merge 18 commits into
Open
it24103309 wants to merge 18 commits into
it24103309 wants to merge 18 commits into
Conversation
Updated Node.js version and repository URL in setup instructions.
Clarified setup instructions for NodeGoat, emphasizing the use of IntelliJ Ultimate and SSH key setup for GitHub.
Updated instructions for running NodeGoat and MongoDB.
Updated comments for clarity regarding the scanning processes and their implications.
Updated GitHub Actions workflow to use newer versions of actions and added Semgrep installation step.
Updated Node.js version in the workflow configuration.
If this causes issues then revert to the commit before this
Updated DAST scanning step to use Docker Compose for starting the NodeGoat application and added waiting logic.
Added permissions for DAST scan to write results to GitHub issues.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NoSQL injection (CWE-943) in getByUserIdAndThreshold() in app/data/allocations-dao.js.
The threshold input was concatenated into a MongoDB $where expression, allowing JS injection. It is now parsed with parseInt and range-checked (0-99); invalid input throws an error. Also added *.bak to .gitignore