Sim events 14582 14666 14640 - #14788
Merged
Merged
Conversation
Importing several SIMEVENTS files together now merges them into one document before coalescing, so keyword events with the same owner, type and timestamp are combined across files, not only within one file. - Add merge_simulator_events_documents, parse_simulator_events_files and apply_simulator_events_files. Source locations carry the file name, so conflict warnings and errors identify both files. - Reject mismatched UNIT, and a second RESTART or duplicate WELSPECS across files. Collect parse errors from all files in one pass. - Warn when files declare the same FILTER name with different expressions, and keep each file's filter instead of reusing the first one. - CLI accepts multiple files; the import dialog allows multi-selection.
INSERT_DATE is now a SCHEDULE event using KEY=VALUE attributes, and the file
format version is bumped to SIMEVENTS 1.2:
<date-expr> INSERT_DATE [EVERY=<duration>] [UNTIL=<date-expr>]
- EVERY takes a duration literal, DURATION variable or expression
(EVERY=1mon, EVERY=30d, EVERY=12mon, EVERY=12h) and must be positive.
Occurrence n is start + n months (clamped), then + n times the fixed part,
which preserves the dates of the previous DAY/MONTH/YEAR recurrences.
- UNTIL is an inclusive end date and requires EVERY; quote values with spaces.
- COMMENT is accepted and ignored; other attributes are rejected.
- SIMEVENTS 1.1 files and old-style INSERT_DATE lines are rejected with a
migration hint showing the rewritten line.
INSERT_DATE statements are now expanded into one timeline event per occurrence instead of a list of bare dates, so each generated date keeps the COMMENT of its statement. - New RimWellEventInsertDate (EventType::INSERT_DATE): a date-only event that generates no keyword, added with WellEventTimeline.add_insert_date_event(event_date, comment). - The schedule generator writes the comment of an insert-date event as "--" lines directly below its DATES keyword. - generate_schedule(_text) no longer takes additional_dates; insert-date events are part of the timeline, but keep the previous behavior of not being filtered by set_timestamp(). - SimulatorEventsDocument.report_dates and ApplyReport.report_dates are replaced by SimulatorEventsDocument.insert_date_events/insert_dates; merging files drops insert dates repeating both date and comment.
The schedule generated from the well event timeline can now be written to file from the GUI, without scripting. - RicScheduleDataGenerator::generateScheduleForTimeline() collects the dates and wells from the timeline (honoring the last applied timestamp, never filtering insert-date events). The Python generate_schedule() method now calls it, so GUI and Python export the same schedule. - New RicExportScheduleFeature "Export Schedule from Events" asks only for the file name and uses fixed defaults: the Eclipse case of the active view (else the first case of the project), MSW keywords for every well with events, the first date as a comment and aligned columns. - Available from the context menu of the well event timeline and the well path collection, and from File -> Export, gated by the new experimental feature "simulator-events-export".
The import and schedule export of simulator events are two halves of the same workflow, so they share the "simulator-events" flag instead of having one keyword each. Users who enabled "simulator-events-import" have to tick the new entry once in Preferences -> System -> Experimental Features.
kriben
force-pushed
the
sim-events-14582-14666-14640
branch
from
September 25, 2026 08:34
649b73a to
2423a63
Compare
magnesj
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14582.
Fixes #14666.
Fixes #14640.