Unify login pipeline to accept an AuthenticatedLogin which the login …#2527
Merged
Conversation
…flow can use to get the login, name and groups. Could not implement a group/claims mapper to WebAPI Roles due to the tight coupling with UserImportJobs and LDAP. Phase2 can incorporate a method of group mapping.
Collaborator
Author
|
I'm going to commit these changes as it unifies the login pipeline, and then my next PR will involve implementing role/claim/nt groups -> webapi Roles functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies the login flow (from authentication to user session + JWT). An un-implemented part of this is how to manage group synchronization. The OIDC attempted to do this, but there is infrastructure in place to manage Group->Role associations, however, it is tightly coupled to LDAP and UserImportJobs. We can decide if we want to maintain the UserImport functioniality, but my prefernce for 3.0 would be to synchronize roles based on user login (at login time, certain auth providers will present claims, so we can do IdP claim->webapi roles mapping during the login process).
I attempted to handle group synchronziaton, but then learned about how the RoleGroupEntity depends on LDAP, UserImportJobs, and I decided to put this into a phase 2 (either we can extend this PR to cover group sync or we can leave this PR to not do group synchronization and juse leave a place-holder for furter expansion to handle group mapping).