Repository navigation
build: raise toolchain to go 1.27.2 - #559
Merged
Merged
Conversation
fank
marked this pull request as ready for review
October 18, 2026 10:16
The 'Check test coverage' step uses a floating
vladopajic/go-test-coverage/action/source@v2 ref. Since v2.20.0
(released 2026-10-03) that tool requires Go >= 1.27, so every main push
since then - the two most recent merges included - failed at the coverage
check:
requires go >= 1.27 (running go 1.26.5; GOTOOLCHAIN=local)
Upgrade the module to go 1.27.2 so the latest coverage tool runs. Verified
locally on go1.27.2: go test passes (only the pre-existing macOS
case-insensitive-filesystem maptoolcli test fails; it passes on Linux CI),
go build/vet clean, and the full coverage pipeline (cover profile + dedupe
+ go-test-coverage v2.20.0) completes successfully.
fank
force-pushed
the
claude/pin-go-test-coverage-v2.19.0
branch
from
October 18, 2026 10:18
fe107de to
080b0e1
Compare
fank
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red Go CI on main for the two most recent merges (#556, #557) and on all currently-open PRs (#558, #554, #220).
Problem
The
Check test coveragestep uses a floating ref:vladopajic/go-test-coverage/action/source@v2. Since upstream released v2.20.0 (2026-10-03), that tool requires Go >= 1.27, but the module declared go 1.26.5. Every main push since then fails at the coverage step (all tests/build pass):Fix
Raise the module toolchain to go 1.27.2 so the (latest) floating coverage tool runs. Only
go.modchanges;go.sumis unchanged.Verification (local, go1.27.2)
go test ./...: all packages pass except one pre-existingmaptoolclitest that requires a case-sensitive filesystem (createsaltis.zip+Altis.zip; macOS APFS collapses them to one file) - this test passes on Linux CI.go build,go vet: clean.go-test-coverage v2.20.0): completes (89.0%, exit 0), i.e. the previously-failing gate now passes.go mod tidyunder go1.27.2: only movesklauspost/compressto a direct require.