Repository navigation
Conversation
New CBA setting OCAP_settings_excludeMarkerTypeFromRecord (stringified array of marker type classnames, default []) so missions can filter out marker types that are used as internal bookkeeping, e.g. zeus players placing Empty markers as readable location notes. Addresses OCAP2/OCAP#99. - MarkerCreated/MarkerUpdated handlers and the initial marker collection skip markers whose markerType is in the list, client-side, exactly like the existing name-prefix exclusion (no network traffic). - Server-side CREATED case applies the same check as defense in depth. - Marker deletions carry no type information and are intentionally not filtered: the server already drops deletions of markers it never tracked, so this keeps markers recorded before the exclusion was enabled deletable. - tests/recorder_regressions.sqf gains a section covering an excluded type, a kept type, the tracked-marker state and both deletions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New CBA setting
OCAP_settings_excludeMarkerTypeFromRecord(stringified array of marker type classnames, default[]) so missions can filter out markers by type — not just by name prefix.Addresses OCAP2/OCAP#99: zeus players place
Empty-type markers as readable location notes, and those can't be filtered with the existing class-name/prefix exclusion. With['Empty']in the new setting they are simply not recorded.Change
XEH_preInit.sqf: new EDITBOX setting in the Exclusions category (global, synced like the other exclusion settings).fnc_handleMarkers.sqf:MarkerCreated/MarkerUpdatedevent handlers skip markers whosemarkerTypeis in the list, client-side (same pattern and placement as the existing name-prefix exclusion — no network traffic).CREATEDcase applies the check too as defense in depth.fnc_init.sqf: parses the setting intoOCAP_recorder_excludeMarkerTypeList(same isNil-guard pattern asOCAP_recorder_excludeMarkerList).tests/recorder_regressions.sqf: new section — creates anEmptymarker and amil_dotmarker with the exclusion active, asserts the excluded type produces no:MARKER:CREATE:, the other type does (and is tracked), and both deletions are handled correctly.Design notes
Empty), consistent withexcludeClassFromRecordsemantics.MarkerDeletedevent carries no type (the marker is already gone). That is safe because the server already drops deletions of markers it never tracked — and it keeps a marker that was recorded before the exclusion was enabled deletable.Verification
hemtt check/hemtt buildrun in CI (the hemtt CLI could not be installed in my local environment; the diff is syntax-reviewed and follows the existing exclusion code patterns verbatim).tests/README.md), same as all other sections — it is not executed by CI.