Skip to content

feat(recorder): pass save tag to extension on :MISSION:SAVE: - #129

Merged
fank merged 1 commit into
mainfrom
claude/export-save-tag
Oct 18, 2026
Merged

fank merged 1 commit into
mainfrom
claude/export-save-tag

Conversation

@fank

@fank fank commented Oct 18, 2026

Copy link
Copy Markdown
Member

What

fnc_exportData.sqf now sends the effective save tag as the first :MISSION:SAVE: argument instead of an empty args array:

[":MISSION:SAVE:", [_saveTag]] call EFUNC(extension,sendData);

_saveTag is the explicit OCAP_exportData third-param override, falling back to the OCAP_settings_saveTag setting (default "TvT"), so the effective tag always ships.

Why

The extension (OCAP2/extension#213, merged) now parses the :MISSION:SAVE: first arg, SQF-unquotes it, and forwards non-empty tags on the streaming end_mission envelope as {"tag":"..."}, which the web (OCAP2/web#571) consumes as the save-tag override. Previously the tag was computed but never left the addon (no-op []).

:EVENT:ENDMISSION: is intentionally untouched — it stays a gameplay (side/message) event; the save tag is a lifecycle/finalization value.

Compatibility

Extensions built before the arg parse ignore :MISSION:SAVE: args entirely, so this degrades silently to today's behavior (tag dropped, mission-start tag used). An empty/blank tag is treated by the extension as "no override".

Test plan

  • HEMTT build + basic SQF sanity (no syntax change beyond one argument).
  • Manual: ["OCAP_exportData", [west, "msg", "myTag"]] call CBA_fnc_serverEvent; → tag reaches web as override.

@fank
fank marked this pull request as ready for review October 18, 2026 16:09
Send the effective save tag (explicit OCAP_exportData override, else the
OCAP_settings_saveTag setting) as the first :MISSION:SAVE: arg so the
extension can forward it on the streaming end_mission envelope as
{"tag":"..."} (OCAP2/extension#213, OCAP2/web#571).

Extensions built before the arg parse ignore :MISSION:SAVE: args, so this
degrades silently to today's behavior.
@fank
fank force-pushed the claude/export-save-tag branch from c2f5f90 to d3f5cc4 Compare October 18, 2026 16:12
@fank

fank commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

🔏 Readiness attested — the pr-readiness-check gate completed for PR #129 at d3f5cc47ed5018ba17aea6ae870d5963afaaf15f (2026-10-18T16:13:19Z). If the branch head has moved, this evidence covers the earlier state only.

Readiness summary

PR Readiness Check (#129, d3f5cc4) — FOLLOW-UP REFRESH
Delta Comment-only (removed the 3-line narration comment; diff is now the bare one-line send: [":MISSION:SAVE:", [_saveTag]]). Classified SMALL.
Branch/base PASS — claude/export-save-tag contains origin/main; worktree clean; local HEAD == PR head.
Local verification SKIP (comment-only delta; no code change since attested c2f5f90; the one-line arg change was previously verified and is compiled by remote build).
Remote CI PASS — addon build (PR run 39143925886, job 117723793353) green at d3f5cc4. Excluded: docs.yml (paths filter, no docs touched), release.yml (push-only deploy).
Coverage NOT REPORTED.
Automated reviewers LIMITATION — gemini-code-assist not enrolled in OCAP2/addon (no bot reviews/comments on any recent PR).
Review threads PASS — 0 reviews.
Review comments PASS — no conversation comments or review bodies on the PR.
Council findings SKIP (operator-waived: comment-only / mechanical).
Standards review SKIP (same waiver).
Spec review SKIP (same waiver).
PR description PASS.
SQL/UI evidence SKIP — no SQL or UI changes.
Result: READY (already-ready PR; new-head attestation published without toggling draft state)

@fank
fank merged commit 61269ee into main Oct 18, 2026
1 check passed
@fank
fank deleted the claude/export-save-tag branch October 18, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant