[19.0][IMP] queue_job: Implement on fail hook - #955
Open
grindtildeath wants to merge 3 commits into
Open
Conversation
Allows to execute a model function when the job fails and will not be retried.
Contributor
This was referenced Jul 24, 2026
Closed
Contributor
|
Just for the record, there were 2 other attempts to manage this
Your approach seem cleaner tho. |
simahawk
reviewed
Jul 27, 2026
| vals = cls._get_failure_values(job, traceback_txt, orig_exception) | ||
| job.set_failed(**vals) | ||
| job.store() | ||
| job.on_fail_hook(vals) |
Contributor
There was a problem hiding this comment.
shall we pass the exception obj too?
| if commit_within_job: | ||
| self.env.cr.commit() # pylint: disable=invalid-commit | ||
|
|
||
| def _test_on_fail_hook(self, **kw): |
Contributor
There was a problem hiding this comment.
If only for testing,this is not needed
florentx
reviewed
Jul 27, 2026
florentx
left a comment
florentx
left a comment
Contributor
There was a problem hiding this comment.
CI fails on test_queue_job add-on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to execute a model function when the job fails and will not be retried.