Repository navigation
fix: render fallback for empty avatar sources - #249
Merged
Merged
Conversation
|
@abhinavrastogi2627 is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
O2sa
approved these changes
Oct 17, 2026
Owner
|
🎊 Welcome, @abhinavrastogi2627! Your first contribution has been merged! 🚀 Thank you for helping improve the project! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
Empty, whitespace-only, null, and undefined avatar sources now render an accessible initial fallback instead of reaching
next/image. This avoids rendering an image with an invalid source while retaining the existing image behavior for valid URLs.Validation:
./node_modules/.bin/vitest run(28 files, 227 tests)./node_modules/.bin/eslint .(passes; one existing warning inleaderboard-table.test.tsx)./node_modules/.bin/tsc --noEmit./node_modules/.bin/prettier --check src/components/layout/avatar.tsx src/components/layout/avatar.test.tsxgit diff --checkAt submission, issue #248 is assigned to me and is not blocked.