Repository navigation
fix(config): the TUI draws every built-in pet and plays its idle animation - #35
Merged
Merged
Conversation
…ation The config window carried one still frame of Clawd and skipped the pet column for any other pet, so the robot and the egg were blank. packs.json now holds each built-in pet's idle frames; the column follows the pet's width and holds the first frame under reduced motion. Signed-off-by: NovusEdge <novusedge0@gmail.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (11)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/glowup configwindow carried one still frame of Clawd and skipped the pet column for any other pet, so the robot and the egg were blank.hooks/packexport.tsexports each built-in pet's idle animation (Clawd, shiny Clawd, robot, egg) intopacks.json, replacing the single Clawd frame. The installer binary grows by about 350 KB.Testing:
just cipasses. New tests cover the export, frame timing, the column width per pet, and the animation with and without reduced motion. The built TUI ran in tmux at 130×40: the robot is drawn and moves between captures, and the egg is drawn.Summary by CodeRabbit
/glowup confignow previews Clawd, shiny Clawd, the robot, and the egg with their idle animations.