Skip to content

Update buildspec.yaml#37

Open
ishu599 wants to merge 1 commit into
NotHarshhaa:masterfrom
ishu599:patch-1
Open

Update buildspec.yaml#37
ishu599 wants to merge 1 commit into
NotHarshhaa:masterfrom
ishu599:patch-1

Conversation

@ishu599
Copy link
Copy Markdown

@ishu599 ishu599 commented Jun 4, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated build pipeline email notification configuration to ensure proper delivery of build status updates.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

πŸ“ Walkthrough

Walkthrough

This PR updates the CodeBuild email notification configuration in buildspec.yaml. A commented SES send-email command and the active post_build phase both change the sender and recipient email addresses to ishuraghuvinder@gmail.com and update the AWS region to eu-north-1.

Changes

Email Notification Configuration

Layer / File(s) Summary
SES email configuration update
DevOps-Project-23/Swiggy_clone/buildspec.yaml
Commented SES command updates sender address, and active post_build phase is rewritten with both --from and --to set to ishuraghuvinder@gmail.com with AWS region changed to eu-north-1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A buildspec update hops into place,
SES emails find their new space,
From Dublin to Nordic shores they'll race,
With addresses shiny and emails so bright,
DevOps gets configured just right! πŸ“§βœ¨

πŸš₯ Pre-merge checks | βœ… 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update buildspec.yaml' is generic and vagueβ€”it describes only the file being changed without conveying the specific nature of the updates (email notification configuration changes). Consider a more descriptive title such as 'Update SES email configuration in buildspec.yaml' to clarify the actual change being made.
βœ… Passed checks (4 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ishu599 ishu599 closed this Jun 4, 2026
@ishu599 ishu599 reopened this Jun 4, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ€– Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@DevOps-Project-23/Swiggy_clone/buildspec.yaml`:
- Around line 58-59: Replace the hardcoded emails used in the SES command
(--from and --to) with Parameter Store references and load them via the
buildspec env.parameter-store configuration; update the buildspec.yaml to
declare parameters (e.g., /cicd/ses/from-email and /cicd/ses/to-email) and
change the SES invocation to use the parameter values instead of literal
addresses so the SES command (the lines containing "--from" and "--to") reads
values from the parameter-store variables; also ensure CI/CD secrets are created
in SSM (aws ssm put-parameter ...) with verified SES addresses before the
pipeline runs.
πŸͺ„ Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0a8698d3-1abd-4bb8-9b5b-1dc87ed78584

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between a38cc0f and 0381f99.

πŸ“’ Files selected for processing (1)
  • DevOps-Project-23/Swiggy_clone/buildspec.yaml

Comment on lines +58 to +59
--from "ishuraghuvinder@gmail.com" \
--to "ishuraghuvinder@gmail.com" \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | πŸ—οΈ Heavy lift

Hardcoded email addresses expose PII and create security/maintainability risks.

Personal email addresses are hardcoded directly in the repository, which:

  • Exposes PII (Personally Identifiable Information) to anyone with repository access
  • Creates a spam/phishing target
  • Makes the configuration inflexible and harder to maintain
  • Violates security best practices for managing sensitive data
πŸ”’ Proposed fix: Use AWS Systems Manager Parameter Store

Store email addresses in Parameter Store and reference them in the buildspec:

Update the env.parameter-store section:

 env:
   parameter-store:
     DOCKER_REGISTRY_USERNAME: /cicd/docker-credentials/username
     DOCKER_REGISTRY_PASSWORD: /cicd/docker-credentials/password
     DOCKER_REGISTRY_URL: /cicd/docker-registry/url
     SONAR_TOKEN: /cicd/sonar/sonar-token
+    NOTIFICATION_FROM_EMAIL: /cicd/ses/from-email
+    NOTIFICATION_TO_EMAIL: /cicd/ses/to-email

Then update the SES command:

 post_build:
   commands:
     - |
       aws ses send-email \
-        --from "ishuraghuvinder@gmail.com" \
-        --to "ishuraghuvinder@gmail.com" \
+        --from "$NOTIFICATION_FROM_EMAIL" \
+        --to "$NOTIFICATION_TO_EMAIL" \
         --subject "CodeBuild Status: $CODEBUILD_BUILD_ID" \
         --text "Build status: $CODEBUILD_BUILD_STATUS" \
         --region "eu-north-1"

Create the parameters:

aws ssm put-parameter --name /cicd/ses/from-email --value "your-verified-email@example.com" --type String
aws ssm put-parameter --name /cicd/ses/to-email --value "recipient@example.com" --type String
πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@DevOps-Project-23/Swiggy_clone/buildspec.yaml` around lines 58 - 59, Replace
the hardcoded emails used in the SES command (--from and --to) with Parameter
Store references and load them via the buildspec env.parameter-store
configuration; update the buildspec.yaml to declare parameters (e.g.,
/cicd/ses/from-email and /cicd/ses/to-email) and change the SES invocation to
use the parameter values instead of literal addresses so the SES command (the
lines containing "--from" and "--to") reads values from the parameter-store
variables; also ensure CI/CD secrets are created in SSM (aws ssm put-parameter
...) with verified SES addresses before the pipeline runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant