Pin setuptools package discovery to neo*#1833
Open
h-mayorquin wants to merge 2 commits intoNeuralEnsemble:masterfrom
Open
Pin setuptools package discovery to neo*#1833h-mayorquin wants to merge 2 commits intoNeuralEnsemble:masterfrom
neo*#1833h-mayorquin wants to merge 2 commits intoNeuralEnsemble:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
include = ["neo*"]to the setuptools package-find config. I am doing this because my local builds are failing underuvwhenever the working copy contains any extra top-level directory (test fixtures, symlinks, generated artifacts), and the same failure will hit any other tool that drives the build on each invocation,pip install -e .,python -m build, CI jobs usinguv sync, and so on. Setuptools auto-discovery refuses to guess when it sees more than one candidate package at the root and aborts the build. Pinning the include list makes the build reproducible regardless of what else lives in the checkout.I think this is a fix but I would like to move away from setuptools at some point towards hatchling for example.