Default missing firstSample to 0 in SpikeGLX reader#1832
Merged
h-mayorquin merged 7 commits intoNeuralEnsemble:masterfrom Apr 21, 2026
Merged
Default missing firstSample to 0 in SpikeGLX reader#1832h-mayorquin merged 7 commits intoNeuralEnsemble:masterfrom
firstSample to 0 in SpikeGLX reader#1832h-mayorquin merged 7 commits intoNeuralEnsemble:masterfrom
Conversation
alejoe91
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1819. Some SpikeGLX
.metafiles do not carryfirstSample, even though it is documented in every phase. The reader accesses it directly in_parse_headerand crashes with a bareKeyError. This PR makes the read defensive and defaults to0.0with aUserWarningnaming the file. Zero is the correct fallback:firstSampleexists to offsett_startfor files that represent a trimmed slice of a longer run, and files that never had it written are not trimmed.I have lifted the read into a new pre-dict step,
_add_first_sample, that follows the pattern of_add_segment_order: it enriches each info dict withinfo["first_sample"]beforesignals_info_dictis built, and the timing loop then reads the prepared field instead of touching the raw meta.