Skip to content

privsep: re-enable capsicum and pledge - #706

Merged
rsmarples merged 1 commit into
masterfrom
sandbox
Aug 14, 2026
Merged

privsep: re-enable capsicum and pledge#706
rsmarples merged 1 commit into
masterfrom
sandbox

Conversation

@rsmarples

Copy link
Copy Markdown
Member

This is a big wups!
Luckily the posix resource limited sandbox is pretty good, but we can do better.

This is a big wups!
Luckily the posix resource limited sandbox is pretty good, but
we can do better.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a7ca6f40-35cf-40ac-92a6-78a74bf3f775

📥 Commits

Reviewing files that changed from the base of the PR and between 50857dd and 9cf3358.

📒 Files selected for processing (1)
  • configure

Walkthrough

Changes

Privilege separation configuration

Layer / File(s) Summary
Set privilege separation flag
configure
The privilege-separation branch now assigns PRIVSEP=yes before detecting the system user and generating configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9cf33

This localized configuration change has no actionable merge-blocking risk identified; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: re-enabling Capsicum and pledge in the privilege-separation sandbox.
Description check ✅ Passed The description relates to the sandboxing changes and explains the need for stronger protection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sandbox

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rsmarples
rsmarples merged commit a14857d into master Aug 14, 2026
22 checks passed
@rsmarples
rsmarples deleted the sandbox branch August 14, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant