Fix board source path overrides#1
Open
NetVar1337 wants to merge 2 commits into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
src/ipunder a nested directory, which prevented correct source/IP lookup for those boards.pcileech-fpgalayout uses a nested100Tsource tree that needs to be referenced separately from the TCL scripts.Description
source_sub_dirboard metadata field (SourceSubDirinBoard) and aSourceBasePathhelper so source/IP paths can be resolved independently of TCL/project paths.SrcPathandIPPathto useSourceBasePathand keepTCLPath/BuildTCLPathbehavior unchanged for TCL files.internal/board/boards.jsonto setsource_sub_dirforZDMAso its sources live underZDMA/100T.TestBoard_SourceSubDirPathsand adjustments to existing board path tests) ininternal/boardto cover the split TCL vs source layout.Testing
go test ./...and all tests completed successfully.SourceBasePath,SrcPath,IPPath, andTCLPathwhich passed under the test run.Codex Task