Skip to content

Fix board source path overrides#1

Open
NetVar1337 wants to merge 2 commits into
mainfrom
codex/enhance-pcileechgen-with-new-features
Open

Fix board source path overrides#1
NetVar1337 wants to merge 2 commits into
mainfrom
codex/enhance-pcileechgen-with-new-features

Conversation

@NetVar1337

Copy link
Copy Markdown
Owner

Motivation

  • Some FPGA board repositories place Vivado TCL scripts at the project root while keeping src/ip under a nested directory, which prevented correct source/IP lookup for those boards.
  • The ZDMA board in the upstream pcileech-fpga layout uses a nested 100T source tree that needs to be referenced separately from the TCL scripts.

Description

  • Add an optional source_sub_dir board metadata field (SourceSubDir in Board) and a SourceBasePath helper so source/IP paths can be resolved independently of TCL/project paths.
  • Change SrcPath and IPPath to use SourceBasePath and keep TCLPath/BuildTCLPath behavior unchanged for TCL files.
  • Update internal/board/boards.json to set source_sub_dir for ZDMA so its sources live under ZDMA/100T.
  • Add and update tests (TestBoard_SourceSubDirPaths and adjustments to existing board path tests) in internal/board to cover the split TCL vs source layout.

Testing

  • Ran go test ./... and all tests completed successfully.
  • Added board path tests exercising SourceBasePath, SrcPath, IPPath, and TCLPath which passed under the test run.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant