feat(koa): Koa 3.x 지원 추가#19
Open
myamaak wants to merge 2 commits into
Open
Conversation
koa를 peerDependency(>=2.0.0)로 명시해 Koa 2.x/3.x를 함께 지원하고, 타입 검증 기준을 @types/koa 3.x로 상향.
Contributor
✅ Changeset detectedLatest commit: ff0618d
If no version change is needed, please add The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@naverpay/prometheus-koa가 Koa 3.x를 공식 지원하도록 변경했습니다. 기존 2.x 사용자 영향은 없습니다.koa를 peerDependency로 명시 (>=2.0.0— Koa 2.x/3.x 동시 지원)@types/koa3.x로 상향@types/koa3.x 상향 시@koa/router팩토리 함수의 추론 반환 타입에서 발생하는타입 이식성 경고(TS2742)를, 라우터 팩토리 3곳(
getKoaMetricsRouter/getNoopRouter/getKoaStandaloneMetricsRouter)에 명시적Router반환 타입을 달아 해소미들웨어·라우터가 v2/v3 공통 API만 사용하므로 런타임 로직 변경은 없습니다.
Koa 3.x breaking change(
ctx.throw시그니처, querystring→URLSearchParams,redirect('back')제거, generator 미들웨어 제거)는 본 패키지에 해당되지 않음을 확인했습니다.