Skip to content

refactor: organize direct FFI backends#43

Open
DjDeveloperr wants to merge 1 commit into
mainfrom
refactor
Open

refactor: organize direct FFI backends#43
DjDeveloperr wants to merge 1 commit into
mainfrom
refactor

Conversation

@DjDeveloperr
Copy link
Copy Markdown
Collaborator

Summary

  • Reorganize NativeScript/ffi so Hermes owns the public JSI entrypoint, direct-engine bridge internals live under ffi/direct, and shared code is named for what it actually shares.
  • Move direct adapters for V8, JSC, and QuickJS off facebook::jsi naming and onto nativescript::direct while keeping Hermes as the only real JSI backend.
  • Centralize signature-dispatch hashing/lookup support, add direct prepared dispatch for V8/JSC/QuickJS, and wire Hermes/RN TurboModule staging to generated signature dispatch.
  • Update CMake, build scripts, RN podspec packaging, and FFI boundary checks to enforce the new architecture.

Validation

  • ./scripts/check_ffi_boundaries.sh
  • git diff --check
  • ./scripts/build_metadata_generator.sh
  • BUILD_SIMULATOR=false BUILD_IPHONE=false BUILD_MACOS=true BUILD_VISION=false BUILD_CATALYST=false ./scripts/build_nativescript.sh --macos --no-iphone --no-simulator --jsc --ffi-direct --gsd-jsc
  • BUILD_SIMULATOR=false BUILD_IPHONE=false BUILD_MACOS=true BUILD_VISION=false BUILD_CATALYST=false ./scripts/build_nativescript.sh --macos --no-iphone --no-simulator --quickjs --ffi-direct --gsd-quickjs
  • BUILD_SIMULATOR=false BUILD_IPHONE=false BUILD_MACOS=true BUILD_VISION=false BUILD_CATALYST=false ./scripts/build_nativescript.sh --macos --no-iphone --no-simulator --v8 --ffi-direct --gsd-v8
  • MACOS_TEST_ENGINE=hermes MACOS_TEST_FFI_BACKEND=direct MACOS_TEST_GSD_BACKEND=hermes ... node scripts/run-tests-macos.js build/test-results/macos-hermes-gsd-on-junit.xml -> 713 specs, 0 failures, 8 skipped
  • MACOS_TEST_ENGINE=hermes MACOS_TEST_FFI_BACKEND=direct MACOS_TEST_GSD_BACKEND=none ... node scripts/run-tests-macos.js build/test-results/macos-hermes-gsd-off-junit.xml -> 713 specs, 0 failures, 8 skipped
  • ./scripts/build_react_native_turbomodule.sh --no-pack

The metadata generation steps still print existing SDK/private-header diagnostics, but the commands exit successfully.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e71f8b93-0a08-41f7-98c6-7630b51ebc19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant