Repository navigation
Open replies from the replies button, five at a time - #91
Merged
Merged
Conversation
The "N replies" button, where a thread can't open in place (a reply on a commit page, notifications and the like), now opens the commit with its replies already showing. "Show more" under a thread opened in a feed does the same. The app now asks devnull for five replies at a time, everywhere: the commit page, threads opened in a feed, and a deleted reply's replies. "Show more" loads the next five. A deleted reply's replies get their own "Show more", since a deleted commit has no page to send you to. A refresh used to drop the pages you'd loaded once there were none left to load. With five a page that would happen all the time, so pages loaded after the first now stay. A reply's page now shows the commit it replies to above it. Only the ones before that fold behind "N earlier commits". A part of a series shows the part before it the same way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to how replies open, all on the commit page.
The replies button now opens the commit with its replies showing. Where a thread can't open in place (a reply's "N replies" on a commit page, notifications, an ancestor's row), the button now lands on the commit with the replies already expanded. "Show more" under a thread opened in a feed does the same.
The app asks for five replies at a time, never more. devnull sends 50 a page unless asked for fewer, so
Clientnow addslimit=5to every GET ofcommits/{id}/replies. The limit isn't part of the response cache key, so the cache's existing patches for new and deleted replies still find the entry. "Show more" loads the next five on the commit page. A deleted reply's replies, opened in place, now page too, with their own "Show more", because a deleted commit has no page to send you to. In a feed, a thread opened in place shows five, and "Show more" opens the commit page.While doing this I hit a refresh bug that five a page makes common: once you'd loaded every page, coming back to the commit dropped everything after the first page and showed "Show more" again. Pages loaded after the first now stay (
withFirstPage()inCommitDetail).A reply's page shows its parent. The commit it replies to now sits above it. Only the ones before that fold behind "N earlier commits". A part of a series shows the part before it the same way, since that's its parent too.
Things to look at:
Screenshots
To follow: I'll add iOS and Android, light and dark, once the app is running from this branch.
🤖 Generated with Claude Code