Repository navigation
Draw quote blocks in commits and remotes, as the web does - #88
Merged
Merged
Conversation
A line that starts with `>` now draws as a quote behind an amber rule on the left, marker dropped, like the web's blockquote from dev-null-sh/dev-null.sh#970. Lines next to each other join one quote, a `>` inside code or mid-line stays as written, and mentions, links and inline code inside a quote work as anywhere else. In your own remotes bubbles the rule takes the bubble's label colour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sonalidudhia
marked this pull request as ready for review
October 26, 2026 06:40
1 task
Member
|
Looks great! Thanks @sonalidudhia |
simonhamp
added a commit
to sonalidudhia/dev-null-app
that referenced
this pull request
Oct 26, 2026
The merge from main brought in the quote splitter from NativePHP#88, which rebuilds every prose run as plain text. It didn't know about color runs, so every swatch was lost. Color runs now pass through untouched, the same as mentions, links and wordmarks. Also puts back the docblock lines the conflict resolution clipped in CommitBody and the message body partial. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
added a commit
that referenced
this pull request
Oct 26, 2026
* Show hex colors with a swatch, as the web does A hex color in a commit or a remote, like #ff8a4c or #fff, now draws after a square of that color, as on the web since dev-null-sh/dev-null.sh#1064. It uses the web's rule: 3, 4, 6 or 8 hex digits, where 3 or 4 digits need a letter or a leading zero so #123 stays an issue number, as a whole word, and never inside code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep hex colors when splitting bodies into quotes The merge from main brought in the quote splitter from #88, which rebuilds every prose run as plain text. It didn't know about color runs, so every swatch was lost. Color runs now pass through untouched, the same as mentions, links and wordmarks. Also puts back the docblock lines the conflict resolution clipped in CommitBody and the message body partial. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Simon <simon.hamp@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line that starts with
>now draws as a quote, as on the web since dev-null-sh/dev-null.sh#970. Until now the app showed the>markers as plain text.CommitBodysplits each paragraph into paragraphs and quotes, following the web'sbodyBlocks(): lines next to each other that start with>join one quote, the marker and one space after it are dropped, and a>inside code or anywhere but a line's start stays as written. Mentions, links and inline code inside a quote work as they do anywhere else.BodyBlockgets a quote kind.lane-5rule on the left, the web's amberborder-(--lane-5). Remotes do the same, and in your own bubbles the rule takes the bubble's label colour, like the web's pale rule there.Tests cover the grouping rules from the web PR's tests (code spans, fenced blocks, mid-line
>, Windows line breaks, a bare>), and screen tests check the rule on a commit and in both kinds of remote bubble.Screenshots
The composer preview of a draft, so nothing was posted. iOS only for now: I don't have an Android emulator set up yet, and will add the Android shots before marking this ready.
composer-preview