Repository navigation
Release 1.0.1: calls without a body and a pulse that rests - #19
Merged
Merged
Conversation
The four packages go to 1.0.1 together, and the three adapters now ask for flutwire ^1.0.1. flutwireVersion and the podspec follow, which version_test checks. The entries that were waiting under Unreleased are now under [1.0.1], each package has its own changelog entry, and the README says what shipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four packages go to 1.0.1: two fixes that are already on main, and a change to the release workflow. A call whose answer has no body, such as a 304, a 204 or the answer to a HEAD request, now ends when its head arrives instead of staying pending with a duration that grows. The recording dot, and the status and time of a running call, beat a few times and rest instead of pulsing for as long as they are on screen.
The second fix is the one that matters. With the inspector open and idle, 1.0.0 kept an Android emulator at 1.5 to 8.5 host cores, with the raster thread of the app at 46 to 59% of a core; this version keeps it at 0.3 to 0.7. With the inspector closed neither version costs anything measurable, and recording a call costs 0.3 to 2 ms of CPU. The emulator numbers are from a debug build and a page of 100 calls, 60 of them unread 304s, and the cost of a call is from the host VM.
This is a patch: it fixes two faults and adds nothing to the API. The release commit moves the four pubspecs, the three adapter constraints,
flutwireVersionand the podspec, whichversion_testchecks, and the entries that were under Unreleased now sit under [1.0.1]. The format check, the analyzer, the four test suites and the publish dry run of each package pass locally. The tag comes after the merge.