Repository navigation
Edit a call and send it again - #10
Merged
Merged
Conversation
A call gets an optional resentFrom id, written in its summary and read back with it. The engine records a call that repeats another whatever the pause and the ignore rules say, because somebody asked for it and is waiting for the answer.
The request leaves through the overrides the app installed, with the capture taken out of the way so the call is recorded once, with the link to the call it repeats. Header fields the client writes itself are left out, and so is any value that still holds the mask the redaction left, because Flutwire never held the real one. A request nobody answers is aborted after two minutes.
A button in the call opens an editor that starts from the recorded method, address, header fields and body. Values the redaction masked are flagged in the field, the address and the body, and are not sent unless typed again. A body that is not text goes out as it was recorded, unless only part of it was kept. The new call opens in place of the editor, is marked in the list, and is linked from its overview to the call it repeats. English and Italian.
|
This pull request adds no capability the code did not already have. 41 files read · 3498 ms · against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opens a recorded call in an editor and sends it again. The editor starts from the method, address, header fields and body that were recorded, and what goes out is recorded as a new call that names the one it repeats. The new call shows in the list with a small replay mark, and its overview links back to the original.
What it does about values it never kept:
Host,Content-Length,Transfer-Encoding,Connection,Keep-Alive) are not offered, so an edited body never goes out with a stale length.How it sends: through
dart:io, with the overrides the app installed, so a proxy or a certificate rule applies here too. The capture is taken out of the way, so the call is recorded once. The recording ignores the pause and the ignore rules, because somebody asked for this call and is waiting to read it. A request nobody answers is aborted after two minutes and recorded as failed.It is not offered on the web, which has no
dart:io, nor for a callable function, which goes through the native SDK and carries credentials Flutwire never sees.FlutwireCallgainsresentFrom.FlutwireSessiongainscanResendandresend, and that interface is not public API.I tried it on an Android emulator with the example app: opened a POST, sent it again, and the new call opened in place of the editor with the link back. All four suites pass and
flutter analyze --fatal-infosis clean.Targets
0.2.0, Tier 2, M15.