Skip to content

Fix __let.hpp __let_t<Tag> get_completion_signatures() computation. #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yulin25 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix __let.hpp __let_t<Tag> get_completion_signatures() computation. #2233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions include/stdexec/__detail/__let.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,23 +624,31 @@ namespace STDEXEC
static_assert(__sender_for<_CvSender, _LetTag>);
using __child_t = __child_of<_CvSender>;
auto __completions = STDEXEC::get_completion_signatures<__child_t, _Env...>();
auto __transform = __get_transform_fn<__fn_t<_CvSender>, __child_t, _Env...>();
if constexpr (!__decay_copyable<_CvSender>)
{
return STDEXEC::__throw_compile_time_error<_SENDER_TYPE_IS_NOT_DECAY_COPYABLE_,
_WITH_PRETTY_SENDER_<_CvSender>>();
}
else if constexpr (__t<_LetTag>() == STDEXEC::set_value)
{
return STDEXEC::__transform_completion_signatures(__completions, __transform);
}
else if constexpr (__t<_LetTag>() == STDEXEC::set_error)

if constexpr (STDEXEC::sender_in<__child_t, _Env...>)
{
return STDEXEC::__transform_completion_signatures(__completions, {}, __transform);
auto __transform = __get_transform_fn<__fn_t<_CvSender>, __child_t, _Env...>();
if constexpr (!__decay_copyable<_CvSender>)
{
return STDEXEC::__throw_compile_time_error<_SENDER_TYPE_IS_NOT_DECAY_COPYABLE_,
_WITH_PRETTY_SENDER_<_CvSender>>();
}
else if constexpr (__t<_LetTag>() == STDEXEC::set_value)
{
return STDEXEC::__transform_completion_signatures(__completions, __transform);
}
else if constexpr (__t<_LetTag>() == STDEXEC::set_error)
{
return STDEXEC::__transform_completion_signatures(__completions, {}, __transform);
}
else
{
return STDEXEC::__transform_completion_signatures(__completions, {}, {}, __transform);
}
}
else
{
return STDEXEC::__transform_completion_signatures(__completions, {}, {}, __transform);
return __completions;
}
}

Expand Down