Skip to content

asioexec::completion_token: Fix Miscompiling Test - #2155

Open
RobertLeahy wants to merge 1 commit into
NVIDIA:mainfrom
RobertLeahy:ipa_modref_20260805
Open

asioexec::completion_token: Fix Miscompiling Test#2155
RobertLeahy wants to merge 1 commit into
NVIDIA:mainfrom
RobertLeahy:ipa_modref_20260805

Conversation

@RobertLeahy

Copy link
Copy Markdown
Contributor

GCC 14 miscompiles the affected test in release without -fno-ipa-modref. GCC 13 and 15 don't seem to have this issue, hence the scope of the workaround.

Reverted 2681e4f (which didn't address the problem fully) and removed the [!mayfail] tag added by 849f989.

Addresses #2023.

@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler ericniebler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. i wonder if there is a source-level pragma that does the same job as the -fno-ipa-modref command line flag. not everybody builds with cmake.

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 82bd95e

GCC 14 miscompiles the affected test in release without -fno-ipa-modref.
GCC 13 and 15 don't seem to have this issue, hence the scope of the
workaround.

Reverted 2681e4f (which didn't address
the problem fully) and removed the [!mayfail] tag added by
849f989.
@RobertLeahy
RobertLeahy force-pushed the ipa_modref_20260805 branch from 82bd95e to f960622 Compare August 7, 2026 20:24
@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test f960622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants