Skip to content

feat(admin-cli): Add Domain creation command - #5660

Draft
kfelternv wants to merge 2 commits into
NVIDIA:mainfrom
kfelternv:feat/domain-create-cli
Draft

feat(admin-cli): Add Domain creation command#5660
kfelternv wants to merge 2 commits into
NVIDIA:mainfrom
kfelternv:feat/domain-create-cli

Conversation

@kfelternv

Copy link
Copy Markdown
Contributor

Adds nico-admin-cli domain create --name <name> so operators can create a DNS Domain through the existing Core CreateDomain RPC and see the created Domain in the configured output format. Domain deletion and REST exposure remain out of scope while their reference and ownership rules are decided.

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

  • cargo test --locked -p nico-admin-cli (235 passed)
  • cargo clippy --locked -p nico-admin-cli --all-targets --all-features -- -D warnings
  • cargo carbide-lints -p nico-admin-cli --all-targets --all-features --locked
  • cargo +nightly-2026-06-16 fmt --all -- --check
  • Exercised domain create --help and the missing---name parser error

Signed-off-by: Kyle Felter <kfelter@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Kyle Felter <kfelter@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant