feat(admin-cli): Add Domain creation command - #5660
Draft
kfelternv wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Kyle Felter <kfelter@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Signed-off-by: Kyle Felter <kfelter@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nico-admin-cli domain create --name <name>so operators can create a DNS Domain through the existing CoreCreateDomainRPC and see the created Domain in the configured output format. Domain deletion and REST exposure remain out of scope while their reference and ownership rules are decided.Related issues
Type of Change
Breaking Changes
Testing
Additional Notes
cargo test --locked -p nico-admin-cli(235 passed)cargo clippy --locked -p nico-admin-cli --all-targets --all-features -- -D warningscargo carbide-lints -p nico-admin-cli --all-targets --all-features --lockedcargo +nightly-2026-06-16 fmt --all -- --checkdomain create --helpand the missing---nameparser error