fix(ssh-console): handle silent Lenovo SOL activation - #5655
Draft
williampnvidia wants to merge 1 commit into
Draft
fix(ssh-console): handle silent Lenovo SOL activation#5655williampnvidia wants to merge 1 commit into
williampnvidia wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lenovo XCC3 can split a failed SOL activation response across multiple SSH
packets. The current implementation can see the initial error text, satisfy its
byte-count check, and declare activation successful before the trailing
system>prompt arrives.The SR650 V4 fallback has the opposite problem: a successful
console startcan transition into SOL without emitting any response. Waiting for positive
output therefore times out even though the console is active.
This change:
system>prompt as activation failureconsole startsuccessRelated issues
Follow-up to #2919 and #2943.
Related to #5173, but this does not address the separate XCC firmware condition
where an SOL channel remains stuck in
In Progress.Type of Change
Breaking Changes
Testing
Validation will include:
cargo +nightly-2026-06-16 fmt --all -- --checkcarbide-ssh-consoletest suitecargo clippy -p carbide-ssh-console --all-targets -- -D warningscargo make --no-workspace clippy-flowAdditional Notes
The same behavior was backported to the exact deployed v2.0.2 source and tested
using the pinned v2.0.2 Linux build container. Its focused Lenovo integration
test, SSH-console integration suite, formatting, clippy, full-workspace release
build, and production-runtime image checks passed.
Live Lenovo XCC3 validation has not yet been performed with the patched image.