fix(devspace): load images into the current kind cluster, not the default named "kind"#3279
Open
mehrdadmoradi-crusoe wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThe ChangesDevSpace image-load hook fix
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ault named 'kind'
The load-images-into-local-cluster hook matches any kind-* kube context but
calls 'kind load docker-image' without --name, so it always targets the
cluster named 'kind' and fails ('no nodes found for cluster "kind"') for any
other cluster name. Derive the cluster name from the current context.
Fixes NVIDIA#3105
Signed-off-by: Mehrdad Moradi <imehrdad2012@gmail.com>
73aad81 to
03f77a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the DevSpace
load-images-into-local-clusterhook so it loads images into the kind cluster of the current kube context, instead of always the cluster namedkind.Related issues
Fixes #3105
Type of Change
Breaking Changes
Testing
The hook matches any
kind-*context but calledkind load docker-imagewithout--name, which defaults to the cluster namedkind. On a cluster with any other name,devspace deployfailed withERROR: no nodes found for cluster "kind".Reproduced and verified locally (context
kind-nico):kind load docker-image <img>→ERROR: no nodes found for cluster "kind".kind load docker-image --name "${CONTEXT#kind-}" <img>→ resolves to thenicocluster and proceeds to load.Additional Notes
One-line change. Context: evaluating NICo for DPU/bare-metal provisioning at Crusoe (NVIDIA Cloud Partner). Happy to adjust the approach.