Skip to content

fix(devspace): load images into the current kind cluster, not the default named "kind"#3279

Open
mehrdadmoradi-crusoe wants to merge 1 commit into
NVIDIA:mainfrom
mehrdadmoradi-crusoe:fix/devspace-kind-load-cluster-name
Open

fix(devspace): load images into the current kind cluster, not the default named "kind"#3279
mehrdadmoradi-crusoe wants to merge 1 commit into
NVIDIA:mainfrom
mehrdadmoradi-crusoe:fix/devspace-kind-load-cluster-name

Conversation

@mehrdadmoradi-crusoe

Copy link
Copy Markdown
Contributor

Fixes the DevSpace load-images-into-local-cluster hook so it loads images into the kind cluster of the current kube context, instead of always the cluster named kind.

Related issues

Fixes #3105

Type of Change

  • Fix - Bug fixes

Breaking Changes

  • This PR contains breaking changes

Testing

  • Manual testing performed

The hook matches any kind-* context but called kind load docker-image without --name, which defaults to the cluster named kind. On a cluster with any other name, devspace deploy failed with ERROR: no nodes found for cluster "kind".

Reproduced and verified locally (context kind-nico):

  • Before: kind load docker-image <img>ERROR: no nodes found for cluster "kind".
  • After: kind load docker-image --name "${CONTEXT#kind-}" <img> → resolves to the nico cluster and proceeds to load.

Additional Notes

One-line change. Context: evaluating NICo for DPU/bare-metal provisioning at Crusoe (NVIDIA Cloud Partner). Happy to adjust the approach.

@mehrdadmoradi-crusoe mehrdadmoradi-crusoe requested a review from a team as a code owner July 8, 2026 20:52
@copy-pr-bot

copy-pr-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a6dae8ff-5978-4a56-8fc8-73e647d0ec94

📥 Commits

Reviewing files that changed from the base of the PR and between 73aad81 and 03f77a7.

📒 Files selected for processing (1)
  • devspace.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • devspace.yaml

Summary by CodeRabbit

  • Bug Fixes
    • Improved local kind cluster image loading during deploys by explicitly targeting the correct cluster name derived from the current kube context, enhancing reliability across different contexts.

Walkthrough

The load-images-into-local-cluster hook in devspace.yaml now passes an explicit --name argument to kind load docker-image, deriving the cluster name from the current kube context so images load into non-default named kind clusters.

Changes

DevSpace image-load hook fix

Layer / File(s) Summary
Add explicit cluster name to kind load command
devspace.yaml
The kind load docker-image invocation now includes --name "${CONTEXT#kind-}", replacing the prior argument-less call that assumed a default cluster name.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately states the main fix: loading images into the current kind cluster instead of the default one.
Description check ✅ Passed The description is clearly related and describes the same DevSpace kind-cluster bug fix and validation.
Linked Issues check ✅ Passed The change matches #3105 by passing the derived kind cluster name to kind load docker-image as expected.
Out of Scope Changes check ✅ Passed No unrelated changes are present; this is a focused one-line fix to the DevSpace hook.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

…ault named 'kind'

The load-images-into-local-cluster hook matches any kind-* kube context but
calls 'kind load docker-image' without --name, so it always targets the
cluster named 'kind' and fails ('no nodes found for cluster "kind"') for any
other cluster name. Derive the cluster name from the current context.

Fixes NVIDIA#3105

Signed-off-by: Mehrdad Moradi <imehrdad2012@gmail.com>
@mehrdadmoradi-crusoe mehrdadmoradi-crusoe force-pushed the fix/devspace-kind-load-cluster-name branch from 73aad81 to 03f77a7 Compare July 9, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(devspace): image-load hook fails for kind clusters not named "kind"

1 participant